tech-toolchain archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: [PATCH] Align libexecinfo unwind.h types to the same clang/gcc header

On 14.01.2020 16:51, Michał Górny wrote:
> On Tue, 2020-01-14 at 16:02 +0100, Joerg Sonnenberger wrote:
>> On Thu, Jan 09, 2020 at 03:36:22PM +0100, Michał Górny wrote:
>>> Update the types and function prototypes used in libexecinfo's unwind.h
>>> to match the more commonly used variants found in clang and gcc.  This
>>> fixes compatibility problems with C++ programs where type mismatches
>>> are errors, and upstreams assume the more common prototypes.  This is
>>> needed to fix compiler-rt and libc++abi builds while not causing any
>>> issues with libexecinfo or other components of src.
>> I'd be more inclined to just drop the libexecinfo copy. The primary
>> reason for its existance is that GCC didn't use to ship one.
> Yeah, I was wondering why it's being shipped in the first place.  Should
> I test whether removing it breaks anything?

If I understand it correctly we can:

 - remove src/include/unistd.h and stop installing /usr/include/unwind.h
 - install src/external/gpl3/gcc/dist/libgcc/unwind-generic.h as
 - redo the same for src/external/gpl3/gcc.old

Just removal will likely break at least libexecinfo.

Attachment: signature.asc
Description: OpenPGP digital signature

Home | Main Index | Thread Index | Old Index