Re: libgmp: duplicate symbol

[Christoph Egger <Christoph_Egger%gmx.de@localhost>]

> On Thu, Dec 13, 2012 at 04:14:36PM +0100, Christoph Egger wrote:

>> Index: external/lgpl3/gmp/dist/gmp-h.in
>> ===================================================================
>> RCS file: /cvsroot/src/external/lgpl3/gmp/dist/gmp-h.in,v
>> retrieving revision 1.2
>> diff -u -p -r1.2 gmp-h.in
>> --- external/lgpl3/gmp/dist/gmp-h.in  2 Jul 2011 14:05:03 -0000       1.2
>> +++ external/lgpl3/gmp/dist/gmp-h.in  12 Dec 2012 14:13:45 -0000
>> @@ -423,7 +423,7 @@ typedef __mpq_struct *mpq_ptr;
>>  #ifdef __GNUC__
>>  #if (defined __GNUC_STDC_INLINE__) || (__GNUC__ == 4 && __GNUC_MINOR__ == 2)
>>  #define __GMP_EXTERN_INLINE extern __inline__ __attribute__ 
>> ((__gnu_inline__))
>> -#else
>> +#elif (__GNUC__ == 4 && __GNUC_MINOR__ > 2)
>>  #define __GMP_EXTERN_INLINE      extern __inline__
>>  #endif
>>  #define __GMP_INLINE_PROTOTYPES  1
> 
> GCC > 4.2 should use the same case GCC 4.2, i.e. with gnu_inline.
> 
> Joerg


Do you think upstream would accept this?

Index: external/lgpl3/gmp/dist/gmp-h.in
===================================================================
RCS file: /cvsroot/src/external/lgpl3/gmp/dist/gmp-h.in,v
retrieving revision 1.2
diff -u -p -r1.2 gmp-h.in
--- external/lgpl3/gmp/dist/gmp-h.in    2 Jul 2011 14:05:03 -0000       1.2
+++ external/lgpl3/gmp/dist/gmp-h.in    13 Dec 2012 20:41:28 -0000
@@ -421,10 +421,8 @@ typedef __mpq_struct *mpq_ptr;
     GCC 4.3 and above with -std=c99 or -std=gnu99 implements ISO C99
     inline semantics, unless -fgnu89-inline is used.  */
 #ifdef __GNUC__
-#if (defined __GNUC_STDC_INLINE__) || (__GNUC__ == 4 && __GNUC_MINOR__ == 2)
+#if (defined __GNUC_STDC_INLINE__) || (__GNUC__ == 4 && __GNUC_MINOR__ >= 2)
 #define __GMP_EXTERN_INLINE extern __inline__ __attribute__ ((__gnu_inline__))
-#else
-#define __GMP_EXTERN_INLINE      extern __inline__
 #endif
 #define __GMP_INLINE_PROTOTYPES  1
 #endif


Christoph