Re: __RCSID() in tools/libelf (Re: CVS commit: src)

[Jason Thorpe <thorpej%shagadelic.org@localhost>]

Please don't check that in; I will handle it in the prepare-import  
script.

-- thorpej@iPhone

On Dec 29, 2009, at 2:53 AM, Izumi Tsutsui <tsutsui%ceres.dti.ne.jp@localhost>  
wrote:

> I wrote:
>
> > build.sh tools on Cygwin 1.7.1 fails around __RCSID() in libelf  
> > sources:
> :
> > It looks we should include "nbtool_config.h" before __RCSID()
> > (or disable it by #if defined(RCSID) etc.) but
> > I wonder what is the common way to handle this.
>
> The attached dumb patch works around the problem.
> (I still wonder where "__unused" keyword should be handled..)
>
> ---
>
> Index: external/bsd/libelf/dist/elf_begin.c
> ===================================================================
> RCS file: /cvsroot/src/external/bsd/libelf/dist/elf_begin.c,v
> retrieving revision 1.3
> diff -u -r1.3 elf_begin.c
> --- external/bsd/libelf/dist/elf_begin.c    20 Dec 2009 23:23:46  
> -0000    1.3
> +++ external/bsd/libelf/dist/elf_begin.c    29 Dec 2009 02:31:46 -0000
> @@ -28,7 +28,9 @@
>
> #include <sys/cdefs.h>
> /* __FBSDID("$FreeBSD: src/lib/libelf/elf_begin.c,v 1.1.10.1.2.1  
> 2009/10/25 01:10:29 kensmith Exp $"); */
> +#if defined(__RCSID)
> __RCSID("$NetBSD: elf_begin.c,v 1.3 2009/12/20 23:23:46 thorpej Exp  
> $");
> +#endif
[.. -8<- .. (cut old patch to reduce size; tech-toolchain-owner)]