Re: CVS commit: src/sys/sys

["Valeriy E. Ushakov" <uwe%stderr.spb.ru@localhost>]

On Wed, Sep 03, 2008 at 23:43:06 +0000, Gregory McGarry wrote:

> Module Name:  src
> Committed By: gmcgarry
> Date:         Wed Sep  3 23:43:06 UTC 2008
> 
> Modified Files:
>       src/sys/sys: fstypes.h
> 
> Log Message:
> Structures with incomplete members is an obscure gcc extension.  Replace the
> flexible array with a zero-length array.  Now compiles on pcc with gcc
> compatibility.

What?  It's not an obscure gcc extension, it's perfectly legal C99.
Cf. 6.7.2.1 Structure and union specifiers

       [#16]  As  a  special  case, the last element of a structure
       with more than one named member may have an incomplete array
       type;  this  is  called  a  flexible  array member.

Please, revert that commit.

SY, Uwe
-- 
uwe%stderr.spb.ru@localhost                       |       Zu Grunde kommen
http://snark.ptc.spbu.ru/~uwe/          |       Ist zu Grunde gehen