--JBi0ZxuS5uaEhkUZ
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sat, Sep 09, 2006 at 01:57:17PM +1000, Simon Burge wrote:
  | Oh, one more point...  Using MKSTATICLIB=3Dno also causes failures
  | for programs that use MKPRIVATELIB libraries.  Is the following
  | OK to commit as well?

How does this work when you do
	make MKSTATICLIB=3Dno ...
?

I was experimenting with expanding the tests in bsd.lib.mk
for MKSTATICLIB!=3Dno to also test for MKPRIVATELIB!=3Dno.

In any case, a clean solution that solves the MKSTATICLIB=3Dno
builds for MKPRIVATELIB=3Dyes as well as for the subset
of libraries that we need libfoo.a for even with MKSTATICLIB=3Dno
is desirable :)


  |=20
  | Cheers,
  | Simon.
  | --
  |=20
  | Index: share/mk/bsd.lib.mk
  | =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
  | RCS file: /cvsroot/src/share/mk/bsd.lib.mk,v
  | retrieving revision 1.268
  | diff -d -p -u -r1.268 bsd.lib.mk
  | --- share/mk/bsd.lib.mk 22 Jul 2006 05:29:03 -0000      1.268
  | +++ share/mk/bsd.lib.mk 9 Sep 2006 03:50:39 -0000
  | @@ -330,6 +330,10 @@ FFLAGS+=3D   ${FOPTS}
  |         ${OBJCOPY} -x ${.TARGET}
  | =20
  |  .if defined(LIB)                                                      =
 # {
  | +.if ${MKPRIVATELIB} !=3D "no"
  | +MKSTATICLIB=3Dyes        # override for local libraries
  | +.endif
  | +
  |  .if (${MKPIC} =3D=3D "no" || (defined(LDSTATIC) && ${LDSTATIC} !=3D ""=
) \
  |         || ${MKLINKLIB} !=3D "no") && ${MKSTATICLIB} !=3D "no"
  |  _LIBS=3Dlib${LIB}.a

--JBi0ZxuS5uaEhkUZ
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (NetBSD)

iD8DBQFFBBxspBhtmn8zJHIRArr9AKCRqulsXx5KlVLomCTvle3usMid5QCfQpwZ
48Vswcl3J9hWcwr2F2MPEjc=
=XSkC
-----END PGP SIGNATURE-----

--JBi0ZxuS5uaEhkUZ--