Subject: Re: Openssl build changes
To: Martin Husemann <firstname.lastname@example.org>
From: Roland Illig <rillig@NetBSD.org>
Date: 12/09/2005 10:44:40
Martin Husemann wrote:
> Hi folks,
> I'm currently testing the attached patches, which I'd like to commit
> together ASAP. They are supposed to fix PR 28935 (64 bit support for
> the bignum library) and PR 32226 (openssl build uses wrong includes).
> I don't like the Makefile change myself, but I have not been able to come
> up with something better - and this works (so far - some test builds
> still going). Any ideas, or is this OK?
Would you mind adding some comments to the Makefile itself, not only the
CVS ChangeLog, that you felt unhappy with the code? Otherwise others
might think this is good style.
> Index: lib/libcrypto/Makefile
> RCS file: /cvsroot/src/lib/libcrypto/Makefile,v
> retrieving revision 1.43
> diff -u -p -r1.43 Makefile
> --- lib/libcrypto/Makefile 25 Nov 2005 20:34:31 -0000 1.43
> +++ lib/libcrypto/Makefile 9 Dec 2005 09:06:56 -0000
> @@ -65,6 +68,11 @@ buildinf.h: Makefile
> CLEANFILES+= buildinf.h
> +cleandir: cleantempsymlinks
> +cleantempsymlinks: .PHONY
> + rm -rf openssl
from the make(1) man page:
.PHONY Apply the .PHONY attribute to any specified sources. Targets
with this attribute do not correspond to actual files; they are
always considered to be out of date, and will not be created
with the -t option.
I think the order should be different, that is, .PHONY should depend on