Subject: Re: Option to make cpp(1) not accept named pipes or devices as
To: Christos Zoulas <christos@zoulas.com>
From: Jim Wise <jwise@draga.com>
List: tech-toolchain
Date: 11/29/2004 18:10:53
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Mon, 29 Nov 2004, Christos Zoulas wrote:

>1. I would call "temp" "only_reg" or something more meaningful.

Done.


>2. I'd kill the second space in 'if ( (temp'

Done.


>3. I would clear non blocking mode after I was done with the IS_REG test:
>     if (temp)
>       (void)fcntl(file->fd, F_SETFL, fcntl(file->fd, F_GETFL, 0) & ~O_NONBLOCK);

Done.


>4. I would prefer to have access to this via a command line flag.

Coming soon.


New patch at same URL:

	http://www.draga.com/~jwise/NetBSD/cpp.diff

- -- 
				Jim Wise
				jwise@draga.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.6 (NetBSD)

iD8DBQFBq6yApRpI6SYACmIRAkJzAKC833W/Sk+JW/tgmX9R0KOndDS2bgCg5fZV
65SFNTrj2DkjAO57pxjXY1k=
=gxJf
-----END PGP SIGNATURE-----