Subject: Re: make should unset $ENV
To: Simon J. Gerraty <firstname.lastname@example.org>
From: James Chacon <email@example.com>
Date: 08/03/2003 00:11:25
"builds" (i.e. building NetBSD) is not the same as, nor has anywhere near
the same scope as changing make's default behavior.
Our make is not only used to build /usr/src. So, making changes to it rather
than build.sh seem misguided at the very least and outright ridiculous
>>> The patch below unsets $ENV at the ealiest opportunity.
>>How far down the road of giving make-executed commands a `standard'
>>environment instead of the user's environment do you want to go?
>Quite a long way ;-)
>>For example, are you going to unset $PATH too? This is not a
>>rhetorical device; I really don't see why you would unset ENV but not
>Well in my builds at work all trees are built in a "sandbox" that does just
>that. Ie. the PATH and environment are sanatized, mk.conf is ignored etc.
>If you want to ensure you can reproduce a build in 5 years, you need to
>be pretty careful about the build env.
>Also sanatizing the build env minimizes the build breaks that can otherwise
>occur when folk have setup their environment for building -current, then try
>to build some old branch.