Subject: Re: ufs includes in src/tools/compat
To: None <firstname.lastname@example.org>
From: Ben Harris <email@example.com>
Date: 05/08/2003 12:05:16
In article <20030508043649.GF510@mewburn.net> you write:
>On Wed, May 07, 2003 at 10:36:44PM -0400, Darrin B. Jewell wrote:
> | While building our toolchain for cross compiling from MacOS X,
> | I discovered a bug in the December Dev Tools supplied by apple.
> | [* see the end of this mail for a description of the bug]
> | I include patches below which work around this bug and which I think
> | are a cleaner construct than that which is currently in our
> | src/tools makefiles. Instead of symlinking the ufs include files
> | into the build directory when building nbinstallboot and nbmakefs,
> | I added reachover include files in src/tools/compat/ufs.
> | Could someone please review and comment on the following patch before
> | I commit it? (It creates new directories under src/tools/compat/ufs
> | in the cvs repository, so it can't be trivially backed out if its the
> | wrong thing.)
>I haven't had a chance to look at this fully, but what are the
>implications of using #includes like this unless the source files are
>explicitly in the same "relative" location?
I think they always will be. The new files are installed under
src/tools/compat, and they reference files under src/sys. I think those
directories are guaranteed to be in the right locations relative to one
>Does this work for objdirs which are done with MAKEOBJDIRPREFIX or
>MAKEOBJDIR (instead of symlinks or local builds)?
Since #include "..." works relative to the including file first, I don't
think there'll be any problem.
Ben Harris <firstname.lastname@example.org>
Portmaster, NetBSD/acorn26 <URL:http://www.netbsd.org/Ports/acorn26/>