On Wed, 28 Nov 2001, Frederick Bruckman wrote:

: > : It shouldn't hurt anything to add BSD_PKG_MK to ${MAKE_ENV}, if that's
: > : what's required.
: >
: > Right, but as I said, I don't know whether this would harm people too.  It's
: > my gut feeling that it'd be better to turn off everything guarded by
: > BSD_PKG_MK in mk.conf, but I wonder if that might exclude some compile
: > options that the builder may actually want.
:
: I'm not sure I follow you. No third party app is going to recognize
: BSD_PKG_MK itself, anyway, so passing it into the package build
: environment will simply tend to meet users expectations as far as
: setting up "/etc/mk.conf" is concerned. "bsd.own.mk" shouldn't care
: about it.

No, what I meant was that someone might put, for instance:

.ifndef BSD_PKG_MK
MANINSTALL=catinstall
.endif

Though visually, it looks like this shouldn't be followed if in pkgsrc, it
has been for BSD-Makefile packages due to this problem.  Adding BSD_PKG_MK
to MAKE_ENV will change this behavior, so it's probably a good idea at least
to make an announcement about it.  (Which would also be a good opportunity to
remind people about the usefulness of BSD_PKG_MK in mk.conf....)

-- 
-- Todd Vierling <tv@wasabisystems.com>  *  Wasabi & NetBSD:  Run with it.
-- CDs, Integration, Embedding, Support -- http://www.wasabisystems.com/