Subject: Re: CVS commit: src/sys
To: Elad Efrat <>
From: Darren Reed <>
List: tech-security
Date: 06/23/2007 17:49:36
Elad Efrat wrote:
> Alistair Crooks wrote:
>> On Sat, Jun 23, 2007 at 01:15:21PM +0300, Elad Efrat wrote:
>>> David Laight wrote:
>>>> Module Name:    src
>>>> Committed By:    dsl
>>>> Date:        Sat Jun 23 09:02:13 UTC 2007
>>>> Modified Files:
>>>>     src/sys/kern: kern_auth.c
>>>>     src/sys/sys: kauth.h
>>>> Log Message:
>>>> Simplify the interfaces needed for sys_setgroups() and 
>>>> sys_getgroups().
>>>> Exposed that the kauth code holds groups in an array, but removes some
>>>> of the knowledge of the maximum number of groups.
>>>> Allows the syscall code to copyin/out directly to/from the cred 
>>>> structure,
>>>> this save a lot of faffing about with malloc/free even when compat 
>>>> code
>>>> has to use 16bit groups.
>>>> To generate a diff of this commit:
>>>> cvs rdiff -r1.47 -r1.48 src/sys/kern/kern_auth.c
>>>> cvs rdiff -r1.37 -r1.38 src/sys/sys/kauth.h
>>>> Please note that diffs are not public domain; they are subject to the
>>>> copyright notices on the relevant files.

Elad, how would you have solved this problem and also
achieved the side benefit of opening up use of NGROUPS
to become a tunable rather than a constant?