Subject: Re: CVS commit: src/sys
To: Elad Efrat <>
From: David Laight <>
List: tech-security
Date: 06/23/2007 17:31:46
On Sat, Jun 23, 2007 at 06:23:44PM +0300, Elad Efrat wrote:
> does "compat code with one less malloc" weighs more than "opaque and
> abstract interface allowing various pluggable secmodels"?

Actually the malloc/free was on every call to sys_set/getgroups,
not just those in the compat code.

One benefit of my changes is that the NGROUPS constant is no
longer in the sys_setgroups() functions, possibly allowing it
to be dynamically changable (etc) without changing the interface
to LKM compat code.


David Laight: