> > - i don't think __CONCAT magic in secmodel_start() is a good idea.
> >   at least, make it SECMODEL_START(), as it can't be a normal function.
> >   also, can you move param.h changes into init_main.c, as it's only place
> >   these definitions are used?
> 
> Will change to SECMODEL_START() and move to init_main.c -- I've been
> planning on removing it from param.h anyway, it can be really annoying
> to rebuild everything. I'll also add a secmodel/secmodel.h to include
> from init_main.c, that in turn includes bsd44.h et al.

given that only one "secmodel" can be compiled in a kernel,
it's better to have secmodel_start() for each secmodel.
__CONCAT here just complicates things unnecessarily, IMO.

YAMAMOTO Takashi