Subject: Re: rpc xid randomness
To: Jun-ichiro itojun Hagino <itojun@itojun.org>
From: Frank van der Linden <fvdl@netbsd.org>
List: tech-security
Date: 09/09/2003 01:25:01
On Tue, Sep 09, 2003 at 08:24:42AM +0900, Jun-ichiro itojun Hagino wrote:
> 	i changed the __RPC_GETXID(), which seems to be for initialization,
> 	that's all.  none of other code is touched.
> 
> 	it seems to me that the library is INCREMENTING rm_xid, rather than
> 	decrementing.  am I right?

It's incrementing it for the dg (UDP) case, and decrementing it for
the vc (TCP) case:

clnt_dg.c:	(*(u_int32_t *)(void *)(cu->cu_outbuf))++;
clnt_vc.c:	x_id = ntohl(--(*msg_x_id));

Anyway, it's fine with me if that is the intended change, I have no
objection to checking that in.

- Frank

-- 
Frank van der Linden                                            fvdl@netbsd.org
===============================================================================
NetBSD. Free, Unix-like OS. > 45 different platforms.    http://www.netbsd.org/