Subject: Re: ktrace and P_SUGID
To: None <>
From: None <>
List: tech-security
Date: 06/30/2002 03:26:02
>> >	     caller->pc_ucred->cr_uid == 0)		<----
>> >		return (1);
>> Hmm, wouldn't it be better to test caller->pc_ucred->cr_uid == 0
>> first?
>no, it wouldn't, but only because the existing check is incorrect.  8-)
>it should be a call to suser() rather than a simple check that uid ==
>0, and it should be at the end (in the same location as the current

	there are other uses of "cr_uid == 0" in sys/kern.  could you
	check if any of these are incorrect or not?
	(obviously, the one within suser() is okay)