tech-pkg archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

redis builds during install



While working on the attached change I noticed that redis performed a full rebuild during 'bmake install' which obviously has a whole host of problems.

If anyone has time and cares enough it would be good to fix. I think it's related to checking the environment for changes to optimisation levels, so it's also possible we're ending up with binaries that are built with completely different flags to what the user has requested.

--
Jonathan Perkin                    pkgsrc.smartos.org
Open Source Complete Cloud   www.tritondatacenter.com
--- Begin Message ---
Module Name:	pkgsrc
Committed By:	jperkin
Date:		Mon Sep  7 08:42:39 UTC 2026

Modified Files:
	pkgsrc/databases/redis: Makefile

Log Message:
redis: Replace interpreter for scripts/build.sh.

Despite a comment at the top of the script saying it is designed for POSIX
sh, it uses the non-portable 'local' keyword.


To generate a diff of this commit:
cvs rdiff -u -r1.105 -r1.106 pkgsrc/databases/redis/Makefile

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: pkgsrc/databases/redis/Makefile
diff -u pkgsrc/databases/redis/Makefile:1.105 pkgsrc/databases/redis/Makefile:1.106
--- pkgsrc/databases/redis/Makefile:1.105	Thu Aug 20 07:52:06 2026
+++ pkgsrc/databases/redis/Makefile	Mon Sep  7 08:42:39 2026
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.105 2026/08/20 07:52:06 adam Exp $
+# $NetBSD: Makefile,v 1.106 2026/09/07 08:42:39 jperkin Exp $
 
 DISTNAME=	redis-8.10.1
 CATEGORIES=	databases
@@ -18,6 +18,8 @@ USE_TOOLS+=		gmake pkg-config
 # Don't let LTO kick in as it is not supported on all platforms.
 MAKE_ENV+=		OPTIMIZATION=${DBG:U-O2:Q}
 
+REPLACE_SH=	scripts/build.sh
+
 .include "../../mk/bsd.prefs.mk"
 
 .include "options.mk"


--- End Message ---


Home | Main Index | Thread Index | Old Index