Re: Firefox 154.0.1 build failure

[Ryo ONODERA <ryo%tetera.org@localhost>]

Hi,

I have no idea why I missed the fix during the laste update...

patches/patch-toolkit_components_remote_nsXRemoteServer.cpp r1.1
should fix the build failure.

Thank you.

Martin Husemann <martin%duskware.de@localhost> writes:

> Unfortunately the bulk builds fail with random/spurious python lossage,
> so I wasn't sure it compiles for anyone:
>
> This is pkgsrc -current from a few hours ago, on NetBSD-current/amd64 from
> last night:
>
> /usr/pkgobj/www/firefox/work/firefox-154.0.1/toolkit/components/remote/nsXRemote
> Server.cpp: In member function 'bool nsXRemoteServer::HandleNewProperty(XID, Dis
> play*, Time, Atom)':
> /usr/pkgobj/www/firefox/work/firefox-154.0.1/toolkit/components/remote/nsXRemoteServer.cpp:113:19: error: 'Success' was not declared in this scope; did you mean 'access'?
>   113 |     if (result != Success || bytes_after != 0) {
>       |                   ^~~~~~~
>       |                   access
>
>
> This is how the function is documented too:
>
>        The function returns Success if it executes successfully.  To free the
>        resulting data, use XFree.
>
> The file properly includes 
>
> #include <X11/Xlib.h>           
> #include <X11/Xatom.h>
>
> and Success should come from 
>
> /usr/X11R7/include/X11/X.h:#define Success                 0    /* everything's okay */
>
> via 
>
> #include <X11/X.h>
>
> in Xlib.h. Any ideas?
>
> Martin

-- 
Ryo ONODERA // ryo%tetera.org@localhost
PGP fingerprint = 82A2 DC91 76E0 A10A 8ABB  FD1B F404 27FA C7D1 15F3