Re: A fix for pkgtools/mksandbox

[Taylor R Campbell <riastradh%NetBSD.org@localhost>]

> Date: Wed, 17 Dec 2025 15:38:46 +1300
> From: Lloyd Parkes <lloyd%must-have-coffee.gen.nz@localhost>
> 
> On 17/12/2025 14:45, Taylor R Campbell wrote:
> 
> > Instead, can we pass configure arguments or something to security/sudo
> > so that it does the right thing?
> 
> Probably not for two reasons. 1) If we knew what the "right" system 
> directory was for configuring security/sudo, we could just put that 
> knowledge into mksandbox. 2) security/sudo will probably refuse to 
> configure if the directory doesn't exist.

Have you tested this hypothesis?

I bet if you do

CONFIGURE_ARGS+=	--with-vardir=${VARBASE}/mumblefrotz/sudo

or

CONFIGURE_ENV+=		sudo_cv_var_dir=${VARBASE}/mumblefrotz/sudo

then it will happily accept that even if the build system doesn't have
a /var/mumblefrotz.

It looks like it only checks for the existence of /var/db, /var/lib,
or /var/adm if you _don't_ specify --with-vardir or sudo_cv_var_dir.

This is also less risky than changing mksandbox during a freeze: if
security/sudo is broken today, well, that's a reason to make changes
to it that fix it without affecting other packages; changes to
mksandbox, however, might affect the whole tree.