Re: fish shell versioning

[Paolo Vincenzo Olivo <vins%NetBSD.org@localhost>]

On 25/12/15 09:50PM, Marcin Gondek wrote:

> devil# fish --version
> fish, version 4.2.1
> devil# fish
> Welcome to fish, the friendly interactive shell
> Type help for instructions on how to use fish
> root@devil ~#
 

Happy to see it works!

> /usr/pkg/lib/libpcre2-8.so
> /usr/pkg/lib/libpcre2-8.so.0
> /usr/pkg/lib/libpcre2-8.so.0.15.0
> /usr/pkg/lib/libpcre2-posix.la
> /usr/pkg/lib/libpcre2-posix.a
> /usr/pkg/lib/libpcre2-posix.so
> /usr/pkg/lib/libpcre2-posix.so.3
> /usr/pkg/lib/libpcre2-posix.so.3.0.7
> /usr/pkg/lib/libpcre2-32.a
> /usr/pkg/lib/libpcre2-32.so
> /usr/pkg/lib/libpcre2-32.so.0
> /usr/pkg/lib/libpcre2-32.so.0.15.0
> /usr/pkg/lib/libpcre2-8.la
> /usr/pkg/lib/libpcre2-8.a
> /usr/pkg/lib/libpcre2-16.a
> /usr/pkg/lib/libpcre2-16.so
> /usr/pkg/lib/libpcre2-16.so.0.15.0
> /usr/pkg/lib/libpcre2-32.la
> /usr/pkg/lib/libpcre2-16.so.0
> /usr/pkg/lib/libpcre2-16.la

This is our pcre2, the one provided by pkgcsrc. On OpenIndiana, the
pcre2 version found in base system was getting leaked, so fish
eventually linked against the latter (this brings the question on
whether we need builtin.mk support for pcre2).

Somehow, pkg-config flags set by the pcre2-sys crate at configure time,
aren't honored throughout the build. Passing the required linker flags
to either cargo (with `-C link-arg=' appended to RUSTFLAGS) or cmake
(through CMAKE_INSTALL_RPATH) won't work and the resulting fish binary
misses the needed runtime library search path.

I opened a issue [1] for this on github, and for the moment it led to
nothing. The conclusion is that I should forward the problem to
rust-pcre2 maintainers.
If anybody has any suggestion to share, please do.
In the meantime, I think we can keep statically linking pcre2 on
shells/fish. 

[1] https://github.com/fish-shell/fish-shell/issues/12165

Regards,
Paolo