Re: Some build breakage to investigate

[Patrick Welche <prlw1%welche.eu@localhost>]

On Thu, Sep 18, 2025 at 08:22:50AM +0000, Patrick Welche wrote:
> [first attempt greylisted]
> 
> On Thu, Sep 18, 2025 at 07:46:24AM +0200, Benny Siegert wrote:
> > Here is some build breakage that someone(TM) should look into:
> >
> > devel/abseil on NetBSD 9: https://releng.netbsd.org/bulktracker/pkg/62454127
> >
> > /usr/include/g++/type_traits:2242:38: error: 'int' is not an enumeration type
> > typedef __underlying_type(_Tp) type;
> 
> That build failure happened with gcc 7.5. This fix looks promising:
> 
> https://github.com/abseil/abseil-cpp/commit/e8c1a5ff2346d40be5f2450044c01c845777cc02
> 
>   Fix check_op(s) compilation failures on gcc 8 which eagerly tries to
>   instantiate std::underlying_type for non-num types. Before cpp20 using
>   std::underlying_t on non enum types is undefined behaviour.
> 
> I don't have NetBSD 9 / old gcc around to test...

It didn't break -current (libreoffice still works), so committed the patch.


Cheers,

Patrick