tech-pkg archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

not cmake fallout in pkgsrc/lang/compiler-rt



On Thu, Feb 13, 2025 at 08:27:18PM +0000, David Brownlee wrote:
> Not been able to build lang/compiler-rt on NetBSD-10 for a couple of
> weeks, possibly since the recent cmake changes
> 
> (it could well be due to something else)
> 
> Can anyone else build lang/compiler-rt OK? Its being pulled in in an
> attempt to build www/chromium

I guess it might have been broken by my patch to add support for
NetBSD-current, but I don't understand how. I'll attach the patch for
review - you can try removing it locally to confirm the theory.

The missing system was moved to its own file on -current, so we need
to include the new header now to get it.

I don't understand why including sys/param.h breaks the old way of
making the symbol available.
 Thomas
$NetBSD: patch-lib_sanitizer__common_sanitizer__linux__libcdep.cpp,v 1.7 2025/02/03 19:55:34 wiz Exp $

Fix build on NetBSD-current, where some symbols moved to a new header.
https://github.com/llvm/llvm-project/issues/125566

--- lib/sanitizer_common/sanitizer_linux_libcdep.cpp.orig	2024-06-15 17:21:32.000000000 +0000
+++ lib/sanitizer_common/sanitizer_linux_libcdep.cpp
@@ -29,7 +29,13 @@
 #  include "sanitizer_solaris.h"
 
 #  if SANITIZER_NETBSD
-#    define _RTLD_SOURCE  // for __lwp_gettcb_fast() / __lwp_getprivate_fast()
+#    // for __lwp_gettcb_fast() / __lwp_getprivate_fast()
+#    include <sys/param.h>
+#    if defined(__NetBSD_Version__) && (__NetBSD_Version__ >= 1099001200)
+#      include <machine/lwp_private.h>
+#    else
+#      define _RTLD_SOURCE
+#    endif
 #  endif
 
 #  include <dlfcn.h>  // for dlsym()


Home | Main Index | Thread Index | Old Index