Re: make php to multi packages

[Greg Troxel <gdt%lexort.com@localhost>]

oskar%fessel.org@localhost writes:

>> But PHP_VERSION_DEFAULT will be set, because in lang/php/phpversion.mk:
>> 
>>  PHP_VERSION_DEFAULT?=           82
>
> We are somewhat arguing in circles. PHP_VERSION_DEFAULT now gets set to 
> something unexpected because the check is not there anymore.  Which 
> probably is a good thing for you. For me it is unexpected and thus not so good.
> No offense meant.

I see what you mean, that it used to get set.

But checking for it not having a value is not going to work.

> A pointer to the documentation _will_ be appreciated.
> I was working under the assumption by using „the source“ that 
> PHP_VERSION_DEFAULT was not needed to be set explicitly because it was 
> automagically set to the installed php version.

See lang/php/phpversion.mk.  That has changed.
>> The only thing that I see as reasonable for someome to do is:
>> 
>>  update the entire pksrc tree to a consistent checkout
>>  run 'pkg_rolling-replace uv'
>>    (so that mismatched and unsafe packages are rebuilt in order)
>
> As mentioned in my previous mail, this was exactly what failed.  Because 
> the need to update php83 before php82 could not be determined by 
> pkg_rolling_replace.

Sorry, but this is inherent in the scheme.  You can either add -k and
let it do what it can and re-run, or figure it out.

>> But the situation is not actually an error; having php83 installed and
>> 82 default is arguably probably not intended, but it would be a bug to
>> fail.
>
> I tend to disagree - it would be a bug to continue.  And currently it aborts after having compiled everything ;-)

It's only a bug for you, because you have config that used to be ok, and
now isn't, and you have an installed binary package that is out of date
relative to the sources.  That puts you into undefined behavior :-)

This is really just "breaking changes are messy".  As I see it, you
asked, there's now clarity, and you know what to do, so having extra
code to deal with this transient edge case doesn't make sense.  I think
it's going to cause more trouble than it's worth.