Please review wip/kvirc-5.2.6; Python.h: No such file or directory; verifypc

[iris000%duck.com@localhost]

I resurrected wip/kvirc and updated it to 5.2.6.

There's a build error with #including <Python.h> that I'm stuck on.

> Information for kvirc-5.2.6:
>
> Comment:
> QT based irc client
>
> Description:
> KVIrc is a free portable IRC client based on the excellent Qt GUI
> toolkit.  KVirc is being written by the KVIrc Development Team with
> the contribution of many IRC addicted developers around the world.
> It has a full GUI based configuration, built-in help browser, addons
> and themes support (configurable from GUI or scripting), transparency
> support, drag'n'drop toolbar editing, activity notifier as well as
> proxy support, SSL and IPv6 sockets support, a modular arch which
> loads modules only when necessary, and a huge API for writing
> extensions.
>
> Homepage:
> https://www.kvirc.net/

kvirc is now based on Qt5.  There is also support for Qt6/KF6 and
Wayland, but I did not attempt them.

"inet6" and "kde" options are enabled by default.  I'm not sure if I
should break out things like Qt WebEngine support into options.  I also
temporarily made "python" into an option for the following problem:



I was able to successfully build out-of-tree against pkgsrc-2024Q3
binary packages on NetBSD/amd64 9.3, but when I build within pkgsrc,
there seems to be some trouble trying to #include <Python.h>, which
returns "No such file or directory:"

> [ 88%] Building CXX object src/modules/pythoncore/CMakeFiles/kvipythoncore.dir/libkvipythoncore.cpp.o
> In file included from /usr/pkgsrc/wip/kvirc/work/KVIrc-5.2.6/src/modules/pythoncore/libkvipythoncore.cpp:38:0:
> /usr/pkgsrc/wip/kvirc/work/KVIrc-5.2.6/src/modules/pythoncore/pythonheaderwrapper.h:10:10: fatal error: Python.h: No such file or directory
>  #include <Python.h>
>           ^~~~~~~~~~
> compilation terminated.
> *** [src/modules/pythoncore/CMakeFiles/kvipythoncore.dir/libkvipythoncore.cpp.o] Error code 1

As far as I know, CMakeCache.txt from both builds seemed to match, and
"find_package(Python3 COMPONENTS Development)" in CMakeLists.txt appears
to be correct and properly fills outs Python3_LIBRARIES and
Python3_INCLUDE_DIRS.

However, if I don't .include "../../lang/python/pyversion.mk" at all,
it still detects Python 3.12.6 in the configure step (but still doesn't
build).  I don't know where to go from here.



I'm also not sure if I'm interpreting the output from verifypc
correctly.  devel/glib2 is brought in by textproc/enchant2, but
otherwise kvirc itself doesn't actually use it at all.

> *** Please use pkgtools/verifypc to sanity check dependencies.
> $ verifypc
> verifypc: glib-2.0 not a direct dependency
> verifypc: gmodule-no-export-2.0 not a direct dependency
> $ pkg_info -n enchant2
> Information for enchant2-2.8.2:
>
> Requires:
> hunspell-en_US-[0-9]*
> hunspell>=1.7.0nb7
> glib2>=2.76.4nb1



--
Iris