Re: websockets cmake woes

[nia <nia%NetBSD.org@localhost>]

On Sun, Oct 13, 2024 at 10:29:05AM -0400, Greg Troxel wrote:
> In /usr/pkg/lib/cmake/libwebsockets/LibwebsocketsTargets.cmake
> there is, apparently directly from upstream:
> 
>   set_target_properties(websockets_shared PROPERTIES
>     INTERFACE_INCLUDE_DIRECTORIES "${_IMPORT_PREFIX}/include;/usr/include"
>     INTERFACE_LINK_LIBRARIES "dl;/usr/lib/libssl.so;/usr/lib/libcrypto.so;/usr/lib/libssl.so;/usr/lib/libcrypto.so"
>   )
> 
> and the result is injecting -ldl into the mosquitto build.  That's wrong
> on many systems, including *BSD.

Any cmake system that hardcodes libdl anywhere is buggy,
there is a straightforward variable available, CMAKE_DL_LIBS,
which will be appropriately set for different platforms.