Re: updating terraform to v1.8.5

[Taylor R Campbell <riastradh%NetBSD.org@localhost>]

> Date: Wed, 9 Oct 2024 12:41:23 -0700
> From: Pete Wright <pete%nomadlogic.org@localhost>
> 
> On 10/9/24 01:50, Leonardo Taccari wrote:
> > Pete Wright writes:
> >> i recently filed this PR:
> >> pkg/58731
> >> https://gnats.netbsd.org/cgi-bin/query-pr-single.pl?number=58731
> > 
> > Nitpit: the LICENSE should be updated too!
> 
> Oh that's a great point - I quickly checked mk/license.mk and didn't see 
> any reference to the "Business Source License" that hashicorp adopted 
> lately.  Interestingly it looks like mariadb doesn't reference a license 
> in the Makefile which is where the Business Source License comes from.
> 
> https://github.com/hashicorp/terraform/blob/main/LICENSE

I wasn't paying close attention when we discused Terraform updates on
IRC the other day, and I assumed all the updates to Terraform was done
with last year's news in mind, but I see now the proposed update is to
1.8.5.

Terraform releases after 1.5.7 are NOT free software (or open source).
They are available ONLY under Hashicorp's proprietary terms.  See
https://www.hashicorp.com/license-faq for details.  It seems that
eventually four-year-old versions of Terraform post-transition will
begin to be released as free software (mpl-2.0) but that won't affect
1.8.5 until the year 2028.

So, this isn't merely a nit that leot picked, I'm afraid:

1. We should probably have terraform-1.5.7 in pkgsrc (and any major
   earlier versions that are needed for incremental transitions from
   old infrastructure).

2. Any newer versions MUST be marked with LICENSE=busl-1.1, and SHOULD
   be packaged (if at all) under another name, such as
   terraform-proprietary or something, so they don't interfere with
   the free software version(s).

3. busl-1.1 MUST NOT be accepted by default in pkgsrc.

(Better to put effort on newer packaging toward opentofu rather than
terraform because of all this!)