tech-pkg archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

deprecating ninja as a package option



gnuradio-core has an option to build with ninja.  Our cmake build
support (devel/cmake/build.mk) has a variable CMAKE_GENERATOR to change
the build tool.  I think that works -- it seemed to in a brief test --
and if not someone should fix it.

Therefore, I think that per-package options to use ninja are not are not
helpful and should be removed.  I will commit this in a day if there
aren't objections, and also in the future feel free to just prune such
support.

I don't think it is worth adding compat to allow the old option; it's
easy enough to fix one's config and the less cruft the better in the
long term.  I suspect very few people, perhaps zero people, are using
this.


--- options.mk.~1.12.~	2024-08-20 13:46:17.000000000 -0400
+++ options.mk	2024-08-20 13:52:20.779854337 -0400
@@ -1,30 +1,13 @@
 # $NetBSD: options.mk,v 1.12 2024/08/20 17:46:17 gdt Exp $
 
 PKG_OPTIONS_VAR=	PKG_OPTIONS.gnuradio
-PKG_SUPPORTED_OPTIONS=	ninja-build filter-design alsa
-# ninja-build is said supported, but not working
+PKG_SUPPORTED_OPTIONS=	filter-design alsa
 # alsa        is said supported, but not good on NetBSD
 
-# Adding ninja-build to following line (now) stops
-# [164/850] cd /PATH/ham/gnuradio-core/work/gnuradio-3.7.5/build/gr-audio/swig && ""
-# FAILED: cd /PATH/ham/gnuradio-core/work/gnuradio-3.7.5/build/gr-audio/swig && ""
-# : permission denied
-
 PKG_SUGGESTED_OPTIONS=	filter-design
 
 .include "../../mk/bsd.options.mk"
 
-.if !empty(PKG_OPTIONS:Mninja-build)
-CMAKE_ARGS+=	-GNinja
-TOOL_DEPENDS+=	ninja-build-[0-9]*:../../devel/ninja-build
-
-do-build:
-	(cd ${WRKSRC}/build; ninja)
-.else
-#do-build:
-#	(cd ${WRKSRC}/build; ${BUILD_MAKE_CMD})
-.endif
-
 .if !empty(PKG_OPTIONS:Mfilter-design)
 PYTHON_VERSIONS_INCOMPATIBLE+=	27 38
 DEPENDS+=	${PYPKGPREFIX}-qtgraph-qt5-[0-9]*:../../x11/py-qtgraph-qt5


Home | Main Index | Thread Index | Old Index