Adding threading support to lang/sbcl

[Kevin Bloom <ktnb%netbsd.org@localhost>]

Hi all,

I've found an issue with our current build of lang/sbcl in which it
isn't compiled with threading support. This means that if you attempt
to use the bordeaux-threads[1] library it won't work. I've tested it
locally and it appears to work as expected useing the attached patch.

Does anyone know of a reason why this wasn't added before or have any
reason why I shouldn't add it? I don't really see the need for making
an option for it as it doesn't change much of anything from a
packaging point of view.


Thanks,

kev

[1] this is a very common library in the Common Lisp community

=== diff ===
RCS file: /cvsroot/pkgsrc/lang/sbcl/Makefile,v
retrieving revision 1.105
diff -u -r1.105 Makefile
--- Makefile    12 Aug 2024 13:45:44 -0000      1.105
+++ Makefile    14 Aug 2024 15:29:59 -0000
@@ -114,7 +114,7 @@

 do-build:
        ${RUN} ${_ULIMIT_CMD} \
-       cd ${WRKSRC} && ${PKGSRC_SETENV} ${MAKE_ENV} ${SH} make.sh --prefix=${PREFIX} ${SBCL_ARCH_ARGS} --xc-host=${SBCL_BOOT_SYSTEM:Q
+       cd ${WRKSRC} && ${PKGSRC_SETENV} ${MAKE_ENV} ${SH} make.sh --prefix=${PREFIX} ${SBCL_ARCH_ARGS} --xc-host=${SBCL_BOOT_SYSTEM:Q --with-sb-thread

 post-build:
        cd ${WRKSRC} && ${RM} -f contrib/sb-cover/test-output/*
=== end diff ===

--- Begin Message ---

• To: tech-pkgs%NetBSD.org@localhost
• Subject: Adding threading support to lang/sbcl

Hi all,

I've found an issue with our current build of lang/sbcl in which it
isn't compiled with threading support. This means that if you attempt
to use the bordeaux-threads[1] library it won't work. I've tested it
locally and it appears to work as expected useing the attached patch.

Does anyone know of a reason why this wasn't added before or have any
reason why I shouldn't add it? I don't really see the need for making
an option for it as it doesn't change much of anything from a
packaging point of view.


Thanks,

kev

[1] this is a very common library in the Common Lisp community

=== diff ===
RCS file: /cvsroot/pkgsrc/lang/sbcl/Makefile,v
retrieving revision 1.105
diff -u -r1.105 Makefile
--- Makefile    12 Aug 2024 13:45:44 -0000      1.105
+++ Makefile    14 Aug 2024 15:29:59 -0000
@@ -114,7 +114,7 @@

 do-build:
        ${RUN} ${_ULIMIT_CMD} \
-       cd ${WRKSRC} && ${PKGSRC_SETENV} ${MAKE_ENV} ${SH} make.sh --prefix=${PREFIX} ${SBCL_ARCH_ARGS} --xc-host=${SBCL_BOOT_SYSTEM:Q}
+       cd ${WRKSRC} && ${PKGSRC_SETENV} ${MAKE_ENV} ${SH} make.sh --prefix=${PREFIX} ${SBCL_ARCH_ARGS} --xc-host=${SBCL_BOOT_SYSTEM:Q} --with-sb-thread

 post-build:
        cd ${WRKSRC} && ${RM} -f contrib/sb-cover/test-output/*
=== end diff ===

--- End Message ---