Re: All packages that use Meson are built with -O0

[Greg Troxel <gdt%lexort.com@localhost>]

Jonathan Schleifer <js%NetBSD.org@localhost> writes:

> Am 11.08.24 um 20:46 schrieb Thomas Klausner:
>
>> and I don't remember you mentioning which package you
>> were trying.
>
> I so far saw this with:
>
>   databases/objpgsql
>   databases/objsqlite3
>   security/cryptopassphrase
>
> What they all have in common is that they use clang over gcc.

Why?  pkgsrc is supposed to respect the user's choice of
PKGSRC_COMPILER.

Does upstream document that they cannot be built with gcc?   

Overwriting PKGSRC_COMPILER means that distcc and ccache, if present,
are lost.

devel/objfw just overwrites, and doesn't have a comment justifying this
irregular situation.

I was ready to SIGUP rilligd, but:

  WARN: Makefile:18: Package sets user-defined "PKGSRC_COMPILER" to "clang", which differs from the default value "gcc" from mk/defaults/mk.conf.

pkglint is, as usual, one step ahead of me.

>> I agree that 'release' would be a better default.
>
> release is -O3. Are we going to just say we're fine with that,
> assuming that software that uses Meson is tested with release and
> hence -O3?
>
> If we want no debug and -O2, the solution would be the commit I linked
> (you can just have no buildtype at all).

No, we want CFLAGS from the environment so when a user sets it, it does
what was asked, just like the other build systems.