* On 2024-08-08 at 18:49 BST, Roland Illig wrote:
Am 08.08.2024 um 09:59 schrieb Jonathan Perkin:* On 2024-08-08 at 07:34 BST, Thomas Klausner wrote:However, pkglint is quite unhappy. The first three happen for every package, the last one for grafana if I follow your suggestion above (making it += will fix this one). ERROR: ../../mk/checksum/checksum.mk:39: Assignment modifiers like ":=" must not be used at all. ERROR: ../../mk/checksum/checksum.mk:96: Assignment modifiers like ":=" must not be used at all. ERROR: ../../mk/checksum/checksum.mk:129: Assignment modifiers like ":=" must not be used at all. WARN: Makefile:16: Assignments to "DISTINFO_ARGMAX_REQD" should use "+=", not "=".Yeh I think we'll need pkglint fixes for these. Using ::= is the only way this is going to work, so while it shouldn't be used in other places, it has to be used here (unless there is some other esoteric bmake feature I should be using instead).I loosened the check, allowing infrastructure files to use the "::=" modifier.
Thanks!
And I assume that it treats all _REQD as needing to be lists. I'm not sure I want to change the name of the variable as I think it accurately depicts what it does, unless there are any better suggestions?For other REQD variables such as GCC_REQD, there may be multiple independent sources, and the highest one wins. From my understanding, this also makes sense for DISTINFO_ARGMAX_REQD, just in case a makefile fragment requires it as well.
Packages only ever have one distinfo file, so it won't ever need to contain multiple values. I'll think of an alternative name.
-- Jonathan Perkin - mnx.io - pkgsrc.smartos.org Open Source Complete Cloud www.tritondatacenter.com