tech-pkg archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: pkgsrc mktool utility



On Mon, 5 Aug 2024 15:08:07 +0100
Jonathan Perkin <jperkin%mnx.io@localhost> wrote:

> If you want to try it out, "cargo install mktool", set 
> TOOLS_PLATFORM.mktool, and apply the following trivial patch:
> 
>    https://github.com/TritonDataCenter/pkgsrc/commit/18c7342525f6a6ab23531ec48be98936984d312b
> 
> My general query is how upset would people be if I committed this patch,
> and others like it in the future?  I wouldn't ever make use of it 
> mandatory, but I would like it to be an easy optional drop-in 
> replacement for any part of the infrastructure where a dedicated tool 
> will far outperform any shell/awk implementation.

There is some prior art with pkgtools/check-portability which
is a golang program that optionally hooks in when it is installed.
So in principle it should be fine, but:

My only objection to the patch posted is that you'll need to have a
version detection strategy from day one if you intend to implement
multiple functions in this binary over time. I will object to any
expensive forking checks in mk/ after how horrendously slow things
became on macOS after mk/compiler/clang.mk 1.43. It really
needs to be reverted and handled via something static in mk.conf,
set by the bootstrap. You can fork a version test if you can prove it's
not too slow.

-Tobias


Home | Main Index | Thread Index | Old Index