Re: Removing built-in support for sqlite3

[Taylor R Campbell <campbell+netbsd-tech-pkg%mumble.net@localhost>]

> Date: Sat, 20 Jul 2024 20:43:55 -0400
> From: Greg Troxel <gdt%lexort.com@localhost>
> 
> Thomas Klausner <wiz%NetBSD.org@localhost> writes:
> 
> > NetBSD comes with sqlite3 in the base system. It mostly imported for
> > supporting a heimdal feature (since disabled) and for apropos(1).
> >
> > The version is not kept up-to-date (NetBSD 10 comes with 3.26, pkgsrc
> > has 3.45). Some software in pkgsrc requires features that are not
> > enabled in the base system version.
> >
> > I'd like to remove builtin support for sqlite3 from pkgsrc (basically,
> > cvs rm databases/sqlite3/builtin.mk).

I think this might not be workable on netbsd-9 (and netbsd-8) because
of netbsd-9's Heimdal sqlite3 mistake.  But, we could limit the
builtin detection to 9 (and 8).  Users who want newer sqlite3 would
have to PREFER_PKGSRC+=heimdal.

(In principle this might break if anything from pkgsrc links against
any other base libraries that link against base libkrb5 or libgssapi
-- but there might not be anything so we might be OK: nothing seems to
use libbind9, libdns, libirs, libisc, libisccc, libisccfg, libns, or
libsaslc from base; see below how I tested like for libkrb5 and
libgssapi.)

For context on Heimdal and sqlite3:
- https://gnats.NetBSD.org/57406
- https://github.com/heimdal/heimdal/issues/1142

> Are there other examples?  Or is this discussion truly about NetBSD 9
> heimdal?

I think it is really limited to netbsd-8/9 Heimdal.

> Checking NetBSD 10, I find sqlite3 linked to
>   /usr/lib/libhdb.so
>   /usr/lib/libkadm5clnt.so
>   /usr/lib/libkadm5srv.so
>   /usr/lib/libkdc.so

Does anything in pkgsrc link against them?  I doubt it -- these are
generally only used by admin programs like kdc and kadmin/kadmind, not
by client and server programs the way libkrb5.so and libgssapi.so are
used extensively by anything that supports GSSAPI authentication.

I grepped through

https://ftp.NetBSD.org/pub/pkgsrc/packages/NetBSD/*/*.0/All/pkg_summary.gz

for REQUIRES lines matching them, and the only ones I found were in
the powerpc heimdal-7.8.0nb7 package (which is undoubtedly broken).

So I don't think they are used.

It is maybe a bug that they are exposed as lib*.so symlinks at all but
I don't think it materially affects pkgsrc.