Re: WRKSRC when using github

[Greg Troxel <gdt%lexort.com@localhost>]

Jason Bacon <jtocino%gmx.com@localhost> writes:

> On 5/19/24 12:06, Greg Troxel wrote:
>> Jason Bacon <jtocino%gmx.com@localhost> writes:
>>
>>> in this case, but building WRKSRC differently depending on whether
>>> GITHUB_TAG is defined seems like a side-effect.  If there's a problem
>>> with using WRKSRC?=${WRKDIR}/${GITHUB_PROJECT}-${GITHUB_TAG:C/^v//}
>>> universally, I'd at least document it.
>>
>>
>> It is totally unreasonable to have definition of WRKSRC that involves
>> anything github, for non-github projects, even if the variables are such
>> that it ends up the same.  But I may be misinterpreting your
>> question/suggestion.
>
> I'm not suggesting that we use github info for non-github packages.
> Only that for github packages, the definition of WRKSRC should not
> depend on whether GITHUB_TAG is defined by the package.

Ah, I misundertood "universally" :-)