Re: portability checking script does not check portability (example: biology/libpll)

[Thomas Klausner <wiz%gatalith.at@localhost>]

On Thu, Jan 25, 2024 at 07:37:10PM +0100, Roland Illig wrote:
> Am 25.01.2024 um 18:51 schrieb Dr. Thomas Orgis:
> > Hi,
> >
> > wiz pointed out to me that he had to clean up after me with
> > biology/libpll and assumed I don't have PKG_DEVELOPER=yes.
> >
> > => Replacing install-sh with pkgsrc version
> > => Checking for portability problems in extracted files
> > checking for a BSD-compatible install... /bin/install -c -o thomas -g thomas
> > checking whether build environment is sane... yes
> 
> In the default configuration, the portability checks are only done on
> files with "#! /some/sh" in the first line. As Makefile.in is not such a
> file, it is skipped.
> 
> To figure this out, I looked at mk/check/check-portability.mk, went to
> check-portability.sh and then to check-portability.awk. After a few dead
> ends, I came back and saw the documentation in check-portability.mk,
> which gives a few hints but is too unspecific to fully make sense of it.
> 
> You can make the portability check stricter for yourself by setting
> CHECK_PORTABILITY_EXPERIMENTAL=yes in your mk.conf. Back in May 2020,
> when I implemented these checks, they broke too many packages, so I made
> them opt-in.

Yes - I have set this by default and build my >2000 packages with
this. Perhaps we should turn this on by default now?
 Thomas