tech-pkg archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: builtin libiconv on macOS 13+



Am 13.11.2023 um 21:55 schrieb Adam:
> By the way, I've also removed empty :U operators, which I think are superfluous - correct me if I'm wrong.

Yes, the ':U' modifiers are indeed superfluous. Not because they are
empty but because the variable BUILTIN_LIB_FOUND.iconv is guaranteed to
be defined at these points. If the variable weren't defined, you'd get a
"Malformed condition" error when evaluating the conditions.

Pkglint doesn't know the API of bsd.builtin.mk and the structure of
builtin.mk files well enough, otherwise it would have suggested your
exact change.

The patch looks good to me.

Roland



Home | Main Index | Thread Index | Old Index