emacs-nox11 failures on macOS

[Greg Troxel <gdt%lexort.com@localhost>]

I just fixed emacs28-nox11 so it will build on macOS.  The basic issue
is that configure finds nextstep (cocoa) and builds a mac thing instead
of normal unix program, and a) PLIST mismatch and b) this is wrong
anyway.

  1) Is it agreed that emacsNN-nox11 means "no GUI toolkits of any
  kind", rather than "no X, but if there is some other native toolkit
  it's ok to use it"?  Seems really obvious to me, but....

  2) Any comments, real or bikeshed, about approach?  I can certainly see:

    # minimal emacs without X, Cocoa, or any other toolkit
    CONFIGURE_ARGS+=	--without-all --without-x --without-ns

  and having it be fewer bytes.   Having written this message I think I
  lean to that.

  3) Does anybody want fixing others to wait until post-freeze, despite
  it being a build fix?   IMHO adding "--without-ns" is very low risk.
  I am building the modified emacs28-nox11 on netbsd 10/amd64.

20 is marked broken on mac (no reason given but 21 is a clue!)
21-nox11 fails in configure with 'not ported', so is BROKEN but not marked
26-nox11 builds and works
27-nox11 fails to package
29-nox11 fails with "non-toolkit scroll bars are not implemented"

--- Begin Message ---

• To: pkgsrc-changes%NetBSD.org@localhost
• Subject: CVS commit: pkgsrc/editors/emacs28-nox11
• From: "Greg Troxel" <gdt%netbsd.org@localhost>
• Date: Mon, 25 Sep 2023 12:12:02 +0000

Module Name:	pkgsrc
Committed By:	gdt
Date:		Mon Sep 25 12:12:02 UTC 2023

Modified Files:
	pkgsrc/editors/emacs28-nox11: Makefile

Log Message:
emacs28-nox11: Force nextstep off to fix macOS build

Despite --without-all, emacs's configure finds and enables nextstep
(cocoa) on macOS, which besides violating the intent to build a
command-line emacs, builds a different set of files and thus fails
packaging.  Explicitly disable nextstep.

With this change, the package builds and runs on macOS.


To generate a diff of this commit:
cvs rdiff -u -r1.1 -r1.2 pkgsrc/editors/emacs28-nox11/Makefile

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: pkgsrc/editors/emacs28-nox11/Makefile
diff -u pkgsrc/editors/emacs28-nox11/Makefile:1.1 pkgsrc/editors/emacs28-nox11/Makefile:1.2
--- pkgsrc/editors/emacs28-nox11/Makefile:1.1	Wed Apr  6 22:41:03 2022
+++ pkgsrc/editors/emacs28-nox11/Makefile	Mon Sep 25 12:12:02 2023
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.1 2022/04/06 22:41:03 wiz Exp $
+# $NetBSD: Makefile,v 1.2 2023/09/25 12:12:02 gdt Exp $
 
 PKGNAME=	${DISTNAME:S/emacs/emacs28/:S/-/-nox11-/}
 CONFLICTS+=	emacs28-[0-9]*
@@ -10,6 +10,10 @@ DISTINFO_FILE=	${.CURDIR}/../../editors/
 
 # minimal emacs without X
 CONFIGURE_ARGS+=	--without-all --without-x
+# on macOS, nextstep (cocoa) is probed for, even if --without-all is
+# given.  Pass it unconditionally, as forcing it off won't hurt on
+# not-mac
+CONFIGURE_ARGS+=	--without-ns
 # but we want to gzip installed files
 CONFIGURE_ARGS+=	--with-compress-install
 

--- End Message ---