GCC_REQD += 10 ? (Re: CVS commit: pkgsrc/ham/gnuradio-core

[Makoto Fujiwara <makoto%ki.nu@localhost>]

Hi Greg, thanks for comment on:

| To: mef%netbsd.org@localhost
| Cc: pkgsrc-changes%netbsd.org@localhost
| Subject: Re: CVS commit: pkgsrc/ham/gnuradio-core
| From: Greg Troxel <gdt%lexort.com@localhost>
| Date: Mon, 21 Aug 2023 05:54:19 -0400

Let me explain why I put GCC_REQD+= 10.

1.
3.10.6.0 to 3.10.7.0 update, tested on 10.99.5
and commit
  
2. pbulk on 9.0 reports following lines with gcc-8.5 ( GCC_REQD += 8)

----------------------------------
[ 58%] Building CXX object gr-filter/lib/CMakeFiles/gnuradio-filter.dir/pm_remez.cc.o

/tmp/ham/gnuradio-core/work/gnuradio-3.10.7.0/gr-filter/lib/pm_remez.cc:
	In function 'constexpr void gr::filter::calc_parms(unsigned int, const
	std::vector<int>&, const std::vector<double>&, const
	std::vector<double>&, const std::vector<double>&,
	std::vector<double>&, std::vector<double>&, std::vector<double>&)':

/tmp/ham/gnuradio-core/work/gnuradio-3.10.7.0/gr-filter/lib/pm_remez.cc:189:12:
	error: call to non-'constexpr' function 
	'std::vector<_Tp,_Alloc>::reference 
	 std::vector<_Tp,_Alloc>::operator[](std::vector<_Tp, _Alloc>::size_type) [with _Tp =double;
	 _Alloc = std::allocator<double>; std::vector<_Tp,_Alloc>::reference = double&;
	 std::vector<_Tp, _Alloc>::size_type = long unsigned int]'

         x[i] = cos(PI2 * Grid[Ext[i]]);
            ^
gmake[2]: *** [gr-filter/lib/CMakeFiles/gnuradio-filter.dir/build.make:258:
               gr-filter/lib/CMakeFiles/gnuradio-filter.dir/pm_remez.cc.o] Error 1
gmake[1]: *** [CMakeFiles/Makefile2:2044: gr-filter/lib/CMakeFiles/gnuradio-filter.dir/all] Error 2
----------------------------------

3.
I've tested on 9.3 with gcc-8.5 ( GCC_REQD += 8)
with

FORCE_C_STD=    c99 ;
FORCE_CXX_STD = c++11;
FORCE_CXX_STD = c++17;
(each)

All fails with the same above problems.

4.
Then put
 GCC_REQD += 10;
(packaged fine) -> commit

Sorry for easy judgement,
-- 
Makoto Fujiwara
mef%NetBSD.org@localhost
makoto%if.t.u-tokyo.ac.jp@localhost
Key fingerprint = 0BFA FAEB EAD1 90BA 7498  8F85 6809 9E0B B7EF A12E
----
pkgsrc freshness:
http://www.ki.nu/~makoto/pkgsrc/check-update/00_Summary.html