tech-pkg archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: [patch] New OS_VARIANT=OpenIndiana in bsd.prefs.mk



* On 2023-08-10 at 19:31 BST, Sijmen J. Mulder wrote:

+_SUN_RELEASE!=		head -n1 /etc/release

Please either make this a delayed variable via :sh or do the != inside each OS_VARIANT section.

Basically you _really_ want to avoid running shell commands unless you absolutely have to - this will cause a reasonable performance hit on SmartOS as it stands.

Otherwise looks good, thanks for adding it.

--
Jonathan Perkin   -   mnx.io   -   pkgsrc.smartos.org
Open Source Complete Cloud   www.tritondatacenter.com


Home | Main Index | Thread Index | Old Index