Re: github.com seems to be changing files again

[David Brownlee <abs%absd.org@localhost>]

On Mon, 29 May 2023 at 01:04, John Klos <john%ziaspace.com@localhost> wrote:
>
> Hi,
>
> I installed ArcticFox on my Alpha machine a few days ago, and it works
> pretty well. Considering that Firefox is dumping core on NetBSD 10/amd64

On that point, try replacing /usr/pkg/bin/firefox with the below

#! /bin/sh
if [ -f /usr/X11R7/lib/libEGL.so ] && [ -z "$LD_PRELOAD" ]; then
    # Temporary workaround
    # This may not avoid a crash 100% of the time, but changes at least some
    # cases of 100% crash on startup to "have not yet seen crash on startup"
    echo "Applying libEGL LD_PRELOAD workaround for NetBSD" >&2
    export LD_PRELOAD=/usr/X11R7/lib/libEGL.so
fi
exec /usr/pkg/lib/firefox/firefox "$@"

> (not on NetBSD 10/aarc64, though), I figured I'd try ArcticFox:
> [...]
> The date on the 41.0 tar.gz is supposed to be 2-April, but it has
> obviously changed in the last few days.
>
> What should we do about this?

The standard sequence is
- Ensure old distfile is on ftp.netbsd.org
- Compare old and new distfiles to check if something nefarious is afoot
- Add or change DIST_SUBDIR so the new distfile is downloaded to a
different place
- Run make mdi, build package, bump PKGREVISION  (if appropriate) and commit
- Reach out to author to see if they can adjust their flow to not trigger this

> In the meanwhile, I've uploaded the known good arcticfox-41.0.tar.gz to
> ftp.NetBSD.org.

I don't think this is the first time this has happened with arcticfox
- last time we didn't have a copy of the old distfile to hand, so we
were not able to see what had changed, but this time we do:

2023-04-02 17:36:04.000000000 +0100
+++ new/Arctic-Fox-41.0/addon-sdk/source/python-lib/cuddlefish/_version.py
    2023-04-02 17:36:04.000000000 +0100
@@ -9,7 +9,7 @@
 # (https://github.com/warner/python-versioneer)

 # these strings will be replaced by git during git-archive
-git_refnames = " (HEAD -> master, tag: v41.0)"
+git_refnames = " (tag: v41.0)"
 git_full = "e4d397a4772655c98f511900b09f583004a42917"

At first glance it looks like this might happen ~every time - if the
tag also matches HEAD on master when it's created, then as soon as
there is another commit it will change.

Uploading an old distfile to ftp.netbsd.org was the most important
action, to fix anyone with an existing checked out tree.

I've just tweaked the Makefile & distinfo and pushed (I'm sure in this
particular case nia@ will forgive me for committing a change without
building first :) so going forward pkgsrc will align with the upstream
distfile.

I've also take the liberty of cc'ing in Riccardo to see if he might
have any thoughts as to how this might be happening, and if he might
be willing to see if something can be tweaked to avoid it (I wonder if
always adding one commit after the tag would avoid it, though I think
there should be something more elegant)

Thanks

David