Re: PLIST override (Re: CVS commit: pkgsrc/games/warzone2100)

[Jonathan Perkin <jperkin%mnx.io@localhost>]

* On 2023-05-17 at 05:41 BST, Frédéric Fauberteau wrote:

> Frédéric Fauberteau wrote:
> > +.if ${OPSYS} == "Darwin"
> > +PLIST_SRC=    PLIST.bundle
> > +.endif
> pkglint prints a lot of error as:
> ERROR: PLIST.bundle:111: Path man/man6/warzone2100.6 is already listed 
> in PLIST:3.
> ERROR: PLIST.bundle:112: Path share/doc/warzone2100/AUTHORS is already 
> listed in PLIST:5.
> ERROR: PLIST.bundle:113: Path share/doc/warzone2100/COPYING is already 
> listed in PLIST:6.
>
> Is it a case not handled by pkglint or is my approach prohibited?

The way I'd handle this is to put the 4 files that Darwin doesn't ship 
behind a ${PLIST.nonbundle} variable:

  $ comm -23 PLIST PLIST.bundle 
  bin/warzone2100
  share/applications/net.wz2100.warzone2100.desktop
  share/icons/net.wz2100.warzone2100.png
  share/metainfo/net.wz2100.warzone2100.appdata.xml

and then move PLIST.bundle to PLIST.Darwin and only include the 
additional "Warzone 2100.app" files in that file.  Simplifies the logic 
in Makefile and should appease pkglint, as well as making future updates 
easier and less error-prone.

--
Jonathan Perkin   -   mnx.io   -   pkgsrc.smartos.org
Open Source Complete Cloud   www.tritondatacenter.com