Re: wip/glusterfs to pkgsrc filesystems/glusterfs

[Thomas Klausner <wiz%NetBSD.org@localhost>]

On Wed, Mar 01, 2023 at 12:49:59AM +0100, Alexander Schreiber wrote:
> > > +BROKEN_ON_PLATFORM+=    *-*-earm*
> > > +BROKEN_ON_PLATFORM+=    *-*-hppa
> > > +BROKEN_ON_PLATFORM+=    *-*-i386
> > > +BROKEN_ON_PLATFORM+=    *-*-m68000
> > > +BROKEN_ON_PLATFORM+=    *-*-m68k
> > > +BROKEN_ON_PLATFORM+=    *-*-mipseb
> > > +BROKEN_ON_PLATFORM+=    *-*-mipsel
> > > +BROKEN_ON_PLATFORM+=    *-*-powerpc
> > > +BROKEN_ON_PLATFORM+=    *-*-riscv32
> > > +BROKEN_ON_PLATFORM+=    *-*-sparc
> > > +BROKEN_ON_PLATFORM+=    *-*-vax
> > 
> > Maybe ONLY_FOR_PLATFORM would be better here? This smells like the code
> > isn't written portably, so probably will fail on anything but amd64 and
> > aarch64 anyway?
> 
> I've successfully tested (built & run) this on all 64bit platforms I have
> available for testing: aarch64, amd64, sparc64. It cannot run (but can be
> built) on any 32bit platform, since the code tries to atomically update
> a 64bit value eventually (userspace-rcu), which is not something that is
> going to work on 32bit (unless you got a weird one). New 32bit platforms
> are unlikely to spring up, but pkgsrc help already mentions e.g. riscv64.
> 
> I would prefer a cleaner ONLY_FOR_64BIT (or similar), but that doesn't
> appear to exist.

BROKEN_ON_PLATFORM=   ${LP32PLATFORMS}

is what you want, I think. Please add a comment to the package
explaining why, too.

Cheers,
 Thomas