Re: Introducing a BUILD_ENV?

[David Brownlee <abs%absd.org@localhost>]

On Sat, 16 Oct 2021 at 16:22, Olaf Seibert <rhialto%netbsd.org@localhost> wrote:
>
> For updating the emulators/simh package, it would be useful to have a
> BUILD_ENV variable. It would be like CONFIGURE_ENV and TEST_ENV:
> added to MAKE_ENV when running do-build (${BUILD_MAKE_CMD}).
>
> The use case for this is that I wanted to separate out the tests, which
> normally run as part of the build. They can be disabled by setting
> TESTS=0, which would nicely fit in BUILD_ENV.
>
> Setting TESTS=0 in MAKE_ENV would cause it to be included in do-test as
> well, which would not help.
>
> I worked around it by defining BUILD_TARGET= TESTS=0 all, but that's
> ugly and pkglint doesn't like it either.
>
> Or is there some other way to approach this?

This seems very reasonable to me - the only concern might be any
interaction with packages which use BUILD_ENV internally for something
else. From a quick search on the web for BUILD_ENV doesn't seem to
throw up anything.

It would be good to get a test build of a reasonable subset of
packages (maybe meta-packages/bulk-small) to confirm it doesn't
explode something else, but unless someone else has a compelling
reason not to add it, I think it should be added.

David