Hi taca@, (tech-pkg@)
I would like to suggest the following change to mail/roundcube/plugins.mk:
> diff -p -u -r1.3 plugins.mk
> --- plugins.mk 14 Jan 2020 14:30:00 -0000 1.3
> +++ plugins.mk 8 Sep 2021 13:30:28 -0000
> @@ -12,14 +12,9 @@ EXTRACT_ELEMENTS?= ${WRKNAME}/${PLUGIN_D
> PLUGIN_DIR?= plugins/${PLUGIN}
> CONF_PLUGINS?= ${PLUGIN}
>
> -#
> -# plugin directory
> -INSTALLATION_DIRS= ${RCDIR}/${PLUGIN_DIR}
> -
> -
> .for f in ${CONF_PLUGINS}
> CONF_FILES_PERMS+= ${EGDIR}/plugins/${f}/config.inc.php \
> - ${RCDIR}/plugins/${f}/config.inc.php \
> + ${PKG_SYSCONFDIR}/${f}.inc.php \
> ${WWW_USER} ${WWW_GROUP} 0640
> .endfor
>
This moves the configuration files for Roundcube plug-ins to $PKG_SYSCONFDIR, where they should belong instead of $RC_DIR/$PLUGIN_DIR.
This works without any further patches, because Roundcube falls back to this when loading configuration for plug-ins:
> else if (!$is_local) {
> // Search plugin_name.inc.php file in any configured path
> return $rcube->config->load_from_file($this->ID . '.inc.php');
> }
(From roundcube/program/lib/Roundcube/rcube_plugin.php)
Can I commit this?
This will also require a PKGREVISION bump on every Roundcube plug-in.
Cheers,
--
khorben
Attachment:
signature.asc
Description: Message signed with OpenPGP