Re: firefox on NetBSD/i386 8.0

[Tobias Nygren <tnn%NetBSD.org@localhost>]

On Tue, 07 Sep 2021 12:08:08 +0200 (CEST)
Havard Eidnes <he%NetBSD.org@localhost> wrote:

> >> it appears to me that this construct from mozilla-common.mk:
> >>
> >> .if !empty(MACHINE_PLATFORM:MNetBSD-8.*-*)
> >> BUILDLINK_DEPMETHOD.gcc8=      full
> >> .include "../../lang/gcc8/buildlink3.mk"
> >> CWRAPPERS_PREPEND.cxx+= \
> >>         -L${BUILDLINK_PREFIX.gcc8}/gcc8/lib \
> >>         ${COMPILER_RPATH_FLAG}${BUILDLINK_PREFIX.gcc8}/gcc8/lib \
> >>         -stdlib++-isystem \
> >>         ${BUILDLINK_PREFIX.gcc8}/gcc8/include/c++ \
> >>         -stdlib++-isystem \
> >>         ${BUILDLINK_PREFIX.gcc8}/gcc8/include/c++/${MACHINE_GNU_PLATFORM} \
> >>         -stdlib++-isystem \
> >>         ${BUILDLINK_PREFIX.gcc8}/gcc8/include/c++/backward
> >> .endif
> >>
> >> doesn't actually work.
> > 
> > I think this broke with Makefile version 1.458 which changed
> > the way pkgsrc, GCC and clang interact.
> > -stdlib++-isystem is a clang option, not a GCC option.
> > 
> >> What to do?
> >
> > Maybe this monstrosity isn't needed any more.
> > What happens if you remove it?
> 
> Testing, it got the build started, at least.

Cool. If there are any parts of the build that still compile C++ STL
code _and_ uses clang++ to do so, then you'll need to hack the
-stdlib++-isystem into those CXXFLAGS only so that GCC and clang use
the same STL library, which is the purpose of the CWRAPPERS_PREPEND
kludge.

-Tobias