Re: gmake 4.3?

[Ryo ONODERA <ryo%tetera.org@localhost>]

Hi,

Ryo ONODERA <ryo%tetera.org@localhost> writes:

> Hi,
>
> Thomas Klausner <wiz%NetBSD.org@localhost> writes:
>
>> On Thu, Apr 29, 2021 at 08:44:19AM -0400, Greg Troxel wrote:
>>> Thomas Klausner <wiz%NetBSD.org@localhost> writes:
>>> 
>>> > Has the world adapted to the changes in gmake 4.3, or are we still
>>> > stuck with 4.2?
>>> 
>>> I don't know, but the question cries out for having gmake 4.3 in wip
>>> (which doesn't seem to be the case) and a bulk build with it.  Even with
>>> just gmake in wip people can install it and see how things go.
>>
>> Good idea - I just added wip/gmake.
>
> Thanks for your wip/gmake-4.3.
> I have gotten the following error of www/firefox in its first stage
> with gmake-4.3.
>
> ===> Building for firefox-88.0nb1
> gmake: *** [/usr/tmp/pkgsrc/www/firefox/work/firefox-88.0/config/rules.mk:355: all] Error 127
> *** Error code 2
>
> I have no idea why other OS/distribution can use GNU make 4.3...
> pkgsrc patches have problems?
> Or does GNU make 4.3 use Linux-specific features?

GNU make 4.3 uses posix_spawn(3) and it dislikes NetBSD's posix_spawn(3)
implementation.
With the following patch, the build of www/firefox does not fail in
its first stage at least.

diff --git a/gmake/Makefile b/gmake/Makefile
index e9069639d7..1f118c9cf9 100644
--- a/gmake/Makefile
+++ b/gmake/Makefile
@@ -2,6 +2,7 @@
 
 DISTNAME=	make-4.3
 PKGNAME=	g${DISTNAME}
+PKGREVISION=	1
 CATEGORIES=	devel
 MASTER_SITES=	${MASTER_SITE_GNU:=make/}
 
@@ -30,6 +31,8 @@ CONFIGURE_ARGS.MirBSD+=	ac_cv_func_strndup=no
 # XXX: based on possible /dev/kmem permissions.
 CONFIGURE_ARGS+=	ac_cv_func_getloadavg_setgid=no
 
+CONFIGURE_ARGS.NetBSD+=	--disable-posix-spawn
+
 AUTO_MKDIRS=		yes
 
 .include "options.mk"


I will try to build misc/libreoffice with wip/gmake-4.3nb1 later.

Thank you.

>>  Thomas
>>
>>
>
> -- 
> Ryo ONODERA // ryo%tetera.org@localhost
> PGP fingerprint = 82A2 DC91 76E0 A10A 8ABB  FD1B F404 27FA C7D1 15F3

-- 
Ryo ONODERA // ryo%tetera.org@localhost
PGP fingerprint = 82A2 DC91 76E0 A10A 8ABB  FD1B F404 27FA C7D1 15F3