Re: [PATCH] If the shell fails the echo test, try /bin/bash

[coypu%sdf.org@localhost]

On Mon, Apr 26, 2021 at 08:18:52PM +0100, Jonathan Perkin wrote:
> * On 2021-04-26 at 19:51 BST, Maya Rashish wrote:
> 
> > Don't have specific code for GNU/kFreeBSD. It is handled the same.
> 
> We only had these workarounds for bad code in the legacy wrappers which
> should be removed anyway.  I'd rather we just removed this stuff completely
> and fix up any places where we're still using incompatible sequences.
> 
> A few years back when I was performing full bulk builds with dash, I had
> these changes:
> 
>   https://github.com/joyent/pkgsrc-legacy/commit/624fd0785e70e89d5e1fef745060efee0aca0da3
>   https://github.com/joyent/pkgsrc-legacy/commit/b7d9205aa23be3e91789c1b0350edc00812baa1a
> 
> The other changes (e.g. fixing configure scripts to use $ac_echo) have
> already been committed.  And obviously I haven't used the legacy wrappers
> for over 5 years now.

GNU/kFreeBSD should be using legacy wrappers still. I think I will
remove the echo test and leave the workarounds for GNU/kFreeBSD in
place, adding a note that they can be removed if switching to cwrappers.

OK?