Re: Cyclic dependency on NetBSD

[maya%NetBSD.org@localhost]

On Wed, Dec 23, 2020 at 10:39:38AM -0500, Greg Troxel wrote:
> 
> Greg Troxel <gdt%lexort.com@localhost> writes:
> 
> > Specifically, what do people think about
> >
> > Index: pkgformat-vars.mk
> > ===================================================================
> > RCS file: /cvsroot/pkgsrc/mk/pkgformat/pkg/pkgformat-vars.mk,v
> > retrieving revision 1.11
> > diff -u -p -r1.11 pkgformat-vars.mk
> > --- pkgformat-vars.mk	18 Dec 2020 17:14:58 -0000	1.11
> > +++ pkgformat-vars.mk	22 Dec 2020 14:21:32 -0000
> > @@ -32,7 +32,11 @@ PKG_INFO_CMD?=		${PKG_TOOLS_BIN}/pkg_inf
> >  LINKFARM_CMD?=		${PKG_TOOLS_BIN}/linkfarm
> >  
> >  # Latest versions of tools required for correct pkgsrc operation.
> > -PKGTOOLS_REQD=		20200828
> > +.if !empty(USE_PKG_ADMIN_DIGEST:M[Yy][Ee][Ss])
> > +PKGTOOLS_REQD=		20191008
> > +.else
> > +PKGTOOLS_REQD=		20100914
> > +.endif
> >  # Latest version of pkg_install required to extract packages
> >  PKGTOOLS_VERSION_REQD=	20091115
> >  
> > With that, pkgin still forces new pkg_install, but cwrappers builds w/o
> > insisting on an update.
> >
> > (I am testing on netbsd-9 before the pullup, so I have pkg_install
> > 20191008 in base.)
> 
> Manuel has reported that this patch works in his pkgbuild environment.
> I agree with his point that people doing bulk builds should not have to
> munge pkg_install tools from the base system.  (I think it's ok to have
> to configure pkg_install.conf.)
> 
> Therefore, I would like to commit this.  However, I would really like
> comments and/or testing from more people.
> 
> So, I'll commit this sometime after 24 0Z December (~8.5 hours from now)
> if I don't hear objections, and perhaps earlier if I get a lot of
> positive comments.

LGTM