tech-pkg archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: [PATCH] pkg_install: fix stage in verbose log message



On Thu, Oct 08, 2020 at 07:09:22PM -0700, Michael Forney wrote:
> On 2020-05-25, Michael Forney <mforney%mforney.org@localhost> wrote:
> > Currently, it always shows PRE-INSTALL, even if it is running with
> > POST-INSTALL.
> > ---
> >  pkgtools/pkg_install/files/add/perform.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> I'd like to submit this change.

Sure!

> Is this something that should come
> with a version bump in files/lib/version.h?

Personally, I think not. But version numbers are cheap...

> How about
> files/configure.ac? Looking through history, I see that sometimes
> version.h is changed, sometimes it isn't, and the version in
> configure.ac is rarely changed (recently there was an 11 year bump).

I'm not aware where this is used. The pkgsrc package uses the version
from version.h, and the internal comparisons (for "is it new enough")
as well.
 Thomas


Home | Main Index | Thread Index | Old Index