tech-pkg archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: Rewrite mk/checksum/checksum in awk

On Fri, Aug 21, 2020 at 06:41:22PM +0100, Jonathan Perkin wrote:
> Hey all,
> While working on an upgrade to www/grafana, I needed to use the new
> support.  This resulted in over 600 distfiles to verify,
> and the current shell script cannot keep up, with a quadratic runtime
> of over 8 minutes for 'bmake checksum'.
> I took the opportunity to rewrite the script in awk:
> and now it takes less than 4 seconds.
> I'm still working through testing this, aiming to support all of the
> perculiar features of the existing script (who knew "IGNORE" was a
> supported checksum?) and retain 100% compatibility, but figured I'd
> throw it out to others for extra testing and review in the meantime.

That's a huge improvement, thank you!

If you find stuff like "IGNORE" that are not used by any packages in
pkgsrc or wip, I think you can propose removal of the functionality.

I didn't know it existed either :)

Home | Main Index | Thread Index | Old Index