Re: enabling WebRTC by default in firefox

[Thomas Klausner <tk%giga.or.at@localhost>]

On Thu, Jun 18, 2020 at 12:15:59PM +0100, Robert Swindells wrote:
> 
> Thomas Klausner <tk%giga.or.at@localhost> wrote:
> >On Fri, May 22, 2020 at 08:42:55PM +0100, Robert Swindells wrote:
> >> >If you attach / commit what you have to wip, I can hack at it from here.
> >> 
> >> <https://ftp.netbsd.org/pub/NetBSD/misc/rjs/libv4l.tar.bz2>
> >> 
> >> I have tested it on NetBSD-current using firefox, not just built the
> >> package.
> >
> >I've added this to wip/libv4l and fixed some minor issues, but it
> >doesn't build because of SSP for me:
> >
> >  CC       v4l1compat_la-v4l1compat.lo
> >v4l1compat.c:115:23: error: redefinition of 'read'
> > LIBV4L_PUBLIC ssize_t read(int fd, void *buffer, size_t n)
> >                       ^~~~
> >In file included from /usr/include/ssp/stdio.h:34,
> >                 from /usr/include/stdio.h:602,
> >                 from ../../lib/include/libv4l1.h:26,
> >                 from v4l1compat.c:31:
> >/usr/include/ssp/unistd.h:39:1: note: previous definition of 'read' was here
> > __ssp_redirect0(ssize_t, read, (int __fd, void *__buf, size_t __len), \
> > ^~~~~~~~~~~~~~~
> >gmake[3]: *** [Makefile:657: v4l1compat_la-v4l1compat.lo] Error 1
> >
> >
> >The old package had workarounds in patch-af and patch-am that just
> >removed that function. Not sure if that breaks any functionality
> >though...
> 
> What is the intended usage of the FORTIFY_SUPPORTED option in a package?
> 
> The package builds with it set to 'no' in the Makefile.

I guess you found the variable intended for disabling this!

It's a quite strange selection of packages that set this:

/usr/pkgsrc/wip/arm-trusted-firmware-sun50i_a64-crust/Makefile:FORTIFY_SUPPORTED=       no
/usr/pkgsrc/editors/vim-share/Makefile.common:FORTIFY_SUPPORTED=        no
/usr/pkgsrc/games/moria/Makefile:FORTIFY_SUPPORTED=     no
/usr/pkgsrc/sysutils/grub2/Makefile:FORTIFY_SUPPORTED=  no
/usr/pkgsrc/sysutils/memtestplus/Makefile:FORTIFY_SUPPORTED=    no
/usr/pkgsrc/mail/hypermail/Makefile:FORTIFY_SUPPORTED=  no
/usr/pkgsrc/www/ap-php/Makefile:FORTIFY_SUPPORTED=      no

 Thomas