Re: graphics/babl: fixes for MacOS

[Joerg Sonnenberger <joerg%bec.de@localhost>]

On Sun, Feb 23, 2020 at 08:08:27AM -0700, Brook Milligan wrote:
> 
> > On Feb 23, 2020, at 7:34 AM, Joerg Sonnenberger <joerg%bec.de@localhost> wrote:
> > 
> > On Sun, Feb 23, 2020 at 11:26:38AM +0000, nia wrote:
> >> 
> >> 
> >> The arguments are transformed by cwrappers.
> >> 
> >> You need to apply the BUILDLINK_TRANSFORM to the transformed arguments,
> >> see the existing lines for appeasing the SunOS linker.
> > 
> > They are usign the split argument version. We don't normalize between
> > the forms. That's a stupid pain to match as separate flags.
> 
> I’m not sure what you are saying here, but the situation with transforms is indeed confusing. 
> 
> The untransformed command ([*] in .work.log) has "-Wl,--version-script,babl.map”.  It would seem, then, that the appropriate BUILDLINK_TRANSFORM should transform that form of the command not something else that has already been transformed.
> 
> Does this mean that the argument splitting precedes the transformation in cwrappers?

Yes.

> Would the opposite order make more sense?

Normally not, since normally you care about the individual flags. The
problem is that some bright minds started to introduce truely separate
flags that can't be as easily detected without hard-coding lots of
flags. Consider something like using colon separated path names.

Joerg